Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing token scopes for wireguard oauth #706

Merged
merged 1 commit into from
May 21, 2024

Conversation

kprosise
Copy link
Contributor

Info was added to what was assumed to be the appropriate spot; will need to be reviewed, and possibly expanded upon.

QA steps: checked rendered output in browser. Edited doc with linters.

No related issue/task, quick-fix to a Customer Success request.

PR Template and Checklist

Please complete as much as possible to speed up the reviewing process.

Readiness and adding reviewers as appropriate is required.

All PRs should be reviewed by a technical writer/documentation team and a peer.
If effecting customers—which is a majority of content changes—a member of Customer Success must also review.

Readiness

  • Merge (pending reviews)
  • Merge after date or event
  • Draft

Overview

Why merge this PR? What does it solve?

Checklist

  • Run spelling and grammar check, preferably with linter.
  • Avoid changing any header associated with a link/reference.
  • Step through instructions (or ask someone to do so).
  • Review for wordiness
  • Match tone and style of page/section.
  • Run make linkcheck.
  • View HTML in a browser to check rendering.
  • Use semantic newlines.
  • follow best practices for commits.
    • Descriptive title written in the imperative.
    • Include brief overview of QA steps taken.
    • Mention any related issues numbers.
    • End message with sign off/DCO line (-s, --signoff).
    • Sign commit with your gpg key (-S, --gpg-sign).
    • Squash commits if needed.
  • Request PR review by a technical writer and at least one peer.

Comments

Any thing else that a maintainer/reviewer should know.
This could include potential issues, rational for approach, etc.

Info was added to what was assumed to be the appropriate spot;
will need to be reviewed, and possibly expanded upon.

QA steps: checked rendered output in browser. Edited doc with linters.

No related issue/task, quick-fix to a Customer Success request.

Signed-off-by: Katrina Prosise <katrina.prosise@foundries.io>
@kprosise kprosise requested review from doanac, caiotpereira and a team May 15, 2024 11:46
@doanac
Copy link
Member

doanac commented May 15, 2024

Copy link
Member

@doanac doanac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea .

@caiotpereira
Copy link
Contributor

LGTM

@kprosise kprosise merged commit dddef8e into foundriesio:main May 21, 2024
2 of 3 checks passed
@kprosise kprosise deleted the add-wireguard-oauth-scope branch May 21, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants