-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ug: offline-update: Adjustments in return codes documentation #711
ug: offline-update: Adjustments in return codes documentation #711
Conversation
Docs for 8c34143 are browsable at: https://ci.foundries.io/projects/fio-docs/builds/2661/docs/artifacts/html/index.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -161,6 +161,8 @@ The ``install`` command sets the following exit codes: | |||
- Reboot is required to complete installation. After reboot ``aklite-offline run`` must be invoked. | |||
- *101*: Installation succeeded. | |||
- Restart of dockerd service is required to complete installation, e.g. ``systemctl restart docker``. After the restart ``aklite-offline run`` must be invoked. | |||
- *102*: Downgrade attempt. | |||
- The Target to be installed has a version lower than the one that is running. The ``--force`` option can be used to force its installation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- The Target to be installed has a version lower than the one that is running. The ``--force`` option can be used to force its installation. | |
- The Target to be installed has a version lower than the one running. Use the ``--force`` option to force its installation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I've applied the suggested change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One optional suggestion, otherwise it LGTM.
Signed-off-by: Andre Detsch <andre.detsch@foundries.io>
This value is not returned anymore. Signed-off-by: Andre Detsch <andre.detsch@foundries.io>
Mention that a new `aklite-offline run` call is required after reboot. Signed-off-by: Andre Detsch <andre.detsch@foundries.io>
Docs for 9b4a87f are browsable at: https://ci.foundries.io/projects/fio-docs/builds/2663/docs/artifacts/html/index.html |
9b4a87f
to
ec552b2
Compare
Docs for ec552b2 are browsable at: https://ci.foundries.io/projects/fio-docs/builds/2664/docs/artifacts/html/index.html |
@kprosise @mike-scott I've added two additional small changes to the PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR Template and Checklist
Please complete as much as possible to speed up the reviewing process.
Readiness and adding reviewers as appropriate is required.
All PRs should be reviewed by a technical writer/documentation team and a peer.
If effecting customers—which is a majority of content changes—a member of Customer Success must also review.
Readiness
Overview
Why merge this PR? What does it solve?
Checklist
make linkcheck
.-s, --signoff
).-S, --gpg-sign
).Comments
Any thing else that a maintainer/reviewer should know.
This could include potential issues, rational for approach, etc.