test: remove test marked as internal #515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mds1
reviewed
Feb 28, 2024
test/StdChains.t.sol
Outdated
Comment on lines
46
to
49
| function testFuzz_Rpc(string memory rpcAlias) internal { | ||
| string memory rpcUrl = getChain(rpcAlias).rpcUrl; | ||
| vm.createSelectFork(rpcUrl); | ||
| } |
There was a problem hiding this comment.
Ah this got accidentally renamed in #433. It should be kept and renamed back to testRpc, where it's used in the commented out testRpcs test below. That test is commented out since testing public RPCs is slow and flaky
mds1
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think there's a way to make this pass either, so I'm removing it.