Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Added text, csv, json_event, json output capability #61

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

aleksandr-mironov-bose
Copy link

@aleksandr-mironov-bose aleksandr-mironov-bose commented Dec 20, 2021

Added output formats:

  • text
  • json
  • csv
  • json_even

@aleksandr-mironov-bose aleksandr-mironov-bose changed the title feature: Added text, csv, json ouput capability feature: Added text, csv, json output capability Dec 20, 2021
@Robby-Swartenbroekx
Copy link

this will implementing the script into some monitoring platform (mostly based on powershell) a whole lot easier.

@yunzheng
Copy link
Member

I like adding csv and json support. However this change doesn’t output the results as they are found anymore, so you have to wait until it finishes the scan.

I know streaming json output could be difficult unless it’s jsonlines. Would powershell support that or does that prefer a single json output?

@tjyang
Copy link

tjyang commented Dec 22, 2021

so you have to wait until it finishes the scan.
This is OK to me, having csv output is useful and need comprise. this new enhancement should have its own argument.

@aleksandr-mironov-bose
Copy link
Author

I like adding csv and json support. However this change doesn’t output the results as they are found anymore, so you have to wait until it finishes the scan.

I know streaming json output could be difficult unless it’s jsonlines. Would powershell support that or does that prefer a single json output?

In case of JSON events your system should be capable to process SerDe(https://docs.aws.amazon.com/athena/latest/ug/json-serde.html). I think that's a good idea to stream JSON events(SerDe), CSV and text. Regular JSON probably requires a scan process to finish first.

@aleksandr-mironov-bose aleksandr-mironov-bose changed the title feature: Added text, csv, json output capability feature: Added text, csv, json_event, json output capability Jan 12, 2022
@aleksandr-mironov-bose
Copy link
Author

aleksandr-mironov-bose commented Jan 12, 2022

I like adding csv and json support. However this change doesn’t output the results as they are found anymore, so you have to wait until it finishes the scan.

I know streaming json output could be difficult unless it’s jsonlines. Would powershell support that or does that prefer a single json output?

I added sync output for text, csv and json_event(SerDe). JSON output returns in the end of scan. It should at any environment(linux, windows, mac) because it doesn't have any specific execution aspects.

@aleksandr-mironov-bose
Copy link
Author

@yunzheng did you have a chance to review this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants