-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: Added text, csv, json_event, json output capability #61
base: main
Are you sure you want to change the base?
Conversation
85e2f48
to
b9deab6
Compare
this will implementing the script into some monitoring platform (mostly based on powershell) a whole lot easier. |
I like adding csv and json support. However this change doesn’t output the results as they are found anymore, so you have to wait until it finishes the scan. I know streaming json output could be difficult unless it’s jsonlines. Would powershell support that or does that prefer a single json output? |
|
In case of JSON events your system should be capable to process SerDe(https://docs.aws.amazon.com/athena/latest/ug/json-serde.html). I think that's a good idea to stream JSON events(SerDe), CSV and text. Regular JSON probably requires a scan process to finish first. |
I added sync output for text, csv and json_event(SerDe). JSON output returns in the end of scan. It should at any environment(linux, windows, mac) because it doesn't have any specific execution aspects. |
@yunzheng did you have a chance to review this? |
Added output formats: