-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
queue: infinite retries after reducing max_tries and bogus retry interval #678
Comments
Pushed 2da4ece that changes the condition to use |
For the record, here's an output without any restarts in between and with the default of 20 retries. The To address
I did notice the the documentations talks about a factor of 1.2 while the code has 1.25, but clearly there is more to this than a simple disparity of the factor. |
Describe the bug
Likely to due a == comparison as opposed to >= , when a email in queue has a retry count higher than
max_retries
, it will be retried infinitely as the condition never matches:maddy/internal/target/queue/queue.go
Line 405 in cee5777
A unrelated secondary issue is seen with the retry delay; which does not match the documented formula; in fact the first 4 retry delays are the same exact 14m59.99 (see logs below). I can file a separate issue if needed.
Steps to reproduce
This can happen in the following situation:
Log files
When maddy was restarted (with different configuration) can be seen by the changing PID.
Configuration file
Environment information
The text was updated successfully, but these errors were encountered: