From b1a813a0809774bdf002be2d253b8ee9ceb64652 Mon Sep 17 00:00:00 2001 From: Taylor Braun-Jones Date: Tue, 27 Aug 2024 21:17:11 -0400 Subject: [PATCH 1/2] Remove atomicity warning that does not apply to STM32 Signed-off-by: Taylor Braun-Jones --- cores/arduino/HardwareSerial.h | 5 ----- 1 file changed, 5 deletions(-) diff --git a/cores/arduino/HardwareSerial.h b/cores/arduino/HardwareSerial.h index bfd94620ba..d319ab3ea5 100644 --- a/cores/arduino/HardwareSerial.h +++ b/cores/arduino/HardwareSerial.h @@ -35,11 +35,6 @@ // location from which to read. // NOTE: a "power of 2" buffer size is recommended to dramatically // optimize all the modulo operations for ring buffers. -// WARNING: When buffer sizes are increased to > 256, the buffer index -// variables are automatically increased in size, but the extra -// atomicity guards needed for that are not implemented. This will -// often work, but occasionally a race condition can occur that makes -// Serial behave erratically. See https://github.com/arduino/Arduino/issues/2405 #if !defined(SERIAL_TX_BUFFER_SIZE) #define SERIAL_TX_BUFFER_SIZE 64 #endif From 0f14ef8db181a013e036db39b7aa9396a30dd7c1 Mon Sep 17 00:00:00 2001 From: Taylor Braun-Jones Date: Tue, 27 Aug 2024 21:30:01 -0400 Subject: [PATCH 2/2] PULL_REQUEST_TEMPLATE.md: Fix broken link to CONTRIBUTING.md Signed-off-by: Taylor Braun-Jones --- .github/PULL_REQUEST_TEMPLATE.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 85f34f3321..56e5df6cd2 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -3,7 +3,7 @@ Please, Make sure that your PR is not a duplicate. Search among the [Pull request](https://github.com/stm32duino/Arduino_Core_STM32/pulls) before creating one. -IMPORTANT: Please review the [CONTRIBUTING.md](../CONTRIBUTING.md) file for detailed contributing guidelines. +IMPORTANT: Please review the [CONTRIBUTING.md](https://github.com/stm32duino/Arduino_Core_STM32/blob/main/CONTRIBUTING.md) file for detailed contributing guidelines. Thanks for submitting a pull request. Please provide enough information so that others can review your pull request: