Fix dead lock with pin above NUM_DIGITAL_PINS (stm32duino#2629)

Penalty for the check should be a single instruction for pin numbers below NUM_DIGITAL_PINS, 9 for pin numbers between PNUM_ANALOG_BASE and NUM_ANALOG_INTERNAL_FIRST. Tests done on a Black F407VE board Signed-off-by: Frederic Pillon <frederic.pillon@st.com> Co-authored-by: Frederic Pillon <frederic.pillon@st.com>
fpistm · Jan 14, 2025 · d8a8b20 · d8a8b20
1 parent cfe4962
commit d8a8b20
Showing 1 changed file with 11 additions and 3 deletions.
diff --git a/cores/arduino/wiring_digital.c b/cores/arduino/wiring_digital.c
@@ -78,17 +78,25 @@ void pinMode(uint32_t ulPin, uint32_t ulMode)
 
 void digitalWrite(uint32_t ulPin, uint32_t ulVal)
 {
-  digitalWriteFast(digitalPinToPinName(ulPin), ulVal);
+  PinName p = digitalPinToPinName(ulPin);
+  if (p != NC) {
+    digitalWriteFast(p, ulVal);
+  }
 }
 
 int digitalRead(uint32_t ulPin)
 {
-  return digitalReadFast(digitalPinToPinName(ulPin));
+  PinName p = digitalPinToPinName(ulPin);
+
+  return (p == NC) ? 0 : digitalReadFast(p);
 }
 
 void digitalToggle(uint32_t ulPin)
 {
-  digitalToggleFast(digitalPinToPinName(ulPin));
+  PinName p = digitalPinToPinName(ulPin);
+  if (p != NC) {
+    digitalToggleFast(digitalPinToPinName(ulPin));
+  }
 }
 
 #ifdef __cplusplus