Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix - Unmarshaling error for Event creation & Feature - Include filtering options for Subscription API #45

Merged
merged 2 commits into from
Jun 20, 2024

Conversation

lil-sahil
Copy link
Contributor

Fixed the marshaling error which was occuring when a single event or a fanout event was created. The issue was occurring due to the fact that the APIResponse from these two endpoints results in a null value being returned for the data field. This resulted in an unmarshaling error in the parseAPIResponse function.

…r a fanout event was created. The issue was occuring due to the fact that the APIResponse from these two endpoints results in a null value being returned for the data field. This resulted in an unmarshaling error in the parseAPIResponse function.
@lil-sahil
Copy link
Contributor Author

Feature: Enhance Subscription API to include additional filtering options

  • Added 'Filter' struct to 'FilterConfiguration' to support filtering by body and headers.

@lil-sahil lil-sahil changed the title Fix - Unmarshaling error for Event creation Fix - Unmarshaling error for Event creation & Feature - Include filtering options for Subscription API Jun 16, 2024
@subomi
Copy link
Contributor

subomi commented Jun 20, 2024

Thanks @lil-sahil

@subomi subomi merged commit ad5d77d into frain-dev:main Jun 20, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants