Lilsahil/feature/endpoint metadata #47
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or 'all' subscription endpoint. Created customString type to handle JSON values that can be either strings or integers. The api response sometimes returns a string or an integer depending on the endpoint that is being hit, so setting the type to a simple int does not resolve the issue - as it will break for other endpoints. - Introduced customString type to manage JSON values that may be strings or integers. - Implemented custom UnmarshalJSON and MarshalJSON methods for customString. - Updated EndpointResponse struct to use customString for fields requiring flexible JSON handling.
lil-sahil
commented
Jun 26, 2024
| } | ||
|
|
||
| func (c *customString) MarshalJSON() ([]byte, error) { | ||
| return json.Marshal(string(*c)) |
There was a problem hiding this comment.
Actually on second thought, does it make sense to return these as integers instead as specified in the API?
|
Hi @lil-sahil , |
|
I'll be taking a look today. @lil-sahil @chili-ios |
|
Hey @lil-sahil,
Essentially, it's not how I want to handle expanding resources, and that's why it wasn't added to this SDK. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature: Added endpoint_metadata information to the response struct for 'all' subscription endpoint. Created customString type to handle JSON values that can be either strings or integers. The api response sometimes returns a string or an integer depending on the endpoint that is being hit, so setting the type to a simple int does not resolve the issue - as it will break for other endpoints.
Fixes #46