-
-
Notifications
You must be signed in to change notification settings - Fork 101
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
1 parent
4bd7e94
commit 81ee696
Showing
1 changed file
with
30 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
81ee696
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@franciscoBSalgueiro sorry to bother you, but this patch looks a bit weird, what was the intention behind it?
What if there is a king moving from g1 to h1 ? This patch would convert this to a castling move or am I wrong?
Is this only for internal conversion and not exposed to the engine ? Otherwise engines will be a bit confused if they send e1h1 (for a frc castling move) and get back (e1g1) for the next position which the gui sends.
81ee696
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right, thanks for catching that.
The issue that I was trying to solve was that stockfish doesn't accept e1h1 as castling, so I was always converting it to e1g1. I'm not considering chess960 yet, because that's not yet working for other reasons as well.
81ee696
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah you are right. Stockfish (and 99% of engines) castling differs in two ways:
Standard is the from square + the to square
FRC/DFRC is the from square + square of the rook that we are castling with.