Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Persist files datatable sorting across view loads #318

Merged
merged 4 commits into from
Jun 22, 2024
Merged

Persist files datatable sorting across view loads #318

merged 4 commits into from
Jun 22, 2024

Conversation

zackschuster
Copy link
Contributor

@zackschuster zackschuster commented Jun 19, 2024 •
edited
Loading

Replaces useState for sort with atomWithStorage & useAtom to persist the sort status to local storage.

@franciscoBSalgueiro
Copy link
Owner

It would be better to use the same persistence system used in all other places in the app, by using jotai and atomWithStorage like here

@zackschuster
Copy link
Contributor Author

Done. The types are much cleaner this way 👍🏻

@franciscoBSalgueiro
Copy link
Owner

Thanks!

@franciscoBSalgueiro franciscoBSalgueiro merged commit 661f97f into franciscoBSalgueiro:master Jun 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zackschuster @franciscoBSalgueiro