Implement clearing of drawables with mouse #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zackschuster
commented
Jun 24, 2024
Comment on lines
-19
to
+31
| if (ref?.current && !api) { | ||
| if (ref?.current == null) return; | ||
| if (api) { | ||
| api?.set({ | ||
| ...props, | ||
| events: { | ||
| change: () => { | ||
| if (props.setBoardFen && api) { | ||
| props.setBoardFen(api.getFen()); | ||
| } | ||
| }, | ||
| }, | ||
| }); | ||
| } else { |
| } | ||
|
|
||
| return state; |
There was a problem hiding this comment.
i assume this function is always supposed to return state, but this branch previously returned nothing.
There was a problem hiding this comment.
The reducer can either return a new state, or simply mutate it when it's inside produce from immer. Since the state is a tree, it can be annoying to ensure immutability, so a lot of these functions are inside produce which doesn't require a return.
There was a problem hiding this comment.
shall i change it back, or is a monomorphic return type acceptable here?
src/components/boards/Board.tsx
Outdated
| <ActionIcon | ||
| variant={editingMode ? "filled" : "default"} | ||
| size="lg" | ||
| onClick={() => setShapes([])} |
There was a problem hiding this comment.
Instead of setShapes, there's already a clearShapes function in store.ts which also sets the dirty flag.
|
thanks! |
franciscoBSalgueiro
changed the title
franciscoBSalgueiro
merged commit 2bba1c7
into
franciscoBSalgueiro:master
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing drawables one-by-one is tedious. This affords an easy way to clear them by:
If the setting is enabled, the "Clear Drawings" button will not be rendered.
Translations for the setting were done with Google Translate.