Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support xfer->cs_change in multi-part SPI messages #9

Open
LouisLambda opened this issue Apr 29, 2023 · 1 comment
Open

support xfer->cs_change in multi-part SPI messages #9

LouisLambda opened this issue Apr 29, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@LouisLambda
Copy link

LouisLambda commented Apr 29, 2023

Hi, thanks for this driver. It's been really useful.

I looked at the stock transfer_one_message implementation from the kernel's [spi.c], and it explicitly handles xfer->cs_change which the this driver currently doesn't. cs_change is meant to tell the SPI driver to momentarily toggle the CS mid-message, since some chips require that to "commit" a command.

@LouisLambda LouisLambda changed the title Issues with CS handling and multi-part transactions support xfer->cs_change in multi-part SPI messages May 2, 2023
@frank-zago frank-zago added the enhancement New feature or request label May 6, 2023
@frank-zago
Copy link
Owner

Could you look at that PR: #16 ?

I didn't find a device whose driver generate a multipart message, so I can't really test. I always see cs_change==0.

If cs_change is not set, and there is a next message, then keep the CS line up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants