-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Energy score estimators #29
base: main
Are you sure you want to change the base?
Conversation
I would put the permutation under the public API function so it's more transparent, and since it can be quite expensive I would also give the option to skip it. Also, I think using We need to add |
Adding it to the backend seems like a good option. Will have a look at
so that we avoid any confusion about in-place operations and not-in-place operations. Won't find time this week, but the week after 👍🏽 |
So, We can set the seed in the function call, i.e. I acknowledge that this current version is somewhat inconsistent because I did |
I would also be in favor of having the seed in the function call. |
Hi there, here we go:
I think we're ready to roll - feedback and criticism welcome. PS: Actually, the last point got me thinking. At some point, showing the speed to estimation precision trade-off might be an interesting case study for an example notebook. |
Hi @sallen12 this is for #25, early-stage work in progress but I'm happy about early feedback.
The
gufunc
s look good in my opinion, the backend based functions are a bit harder. For numpy, it's quite straight-forward to justnp.permutation
or to subset by a sampled index. For the other backends, I'm not too sure what is the appropriate way to to shuffle the ensemble members once. Do you got an idea here?