Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[[unlikely]] attribute requires C++20 #29

Closed
Trinitou opened this issue Nov 21, 2023 · 0 comments · Fixed by #30
Closed

[[unlikely]] attribute requires C++20 #29

Trinitou opened this issue Nov 21, 2023 · 0 comments · Fixed by #30

Comments

@Trinitou
Copy link
Contributor

Trinitou commented Nov 21, 2023 •
edited
Loading

Moved over from free-audio/clap#364

The problem is that the [[unlikely]] attribute is used in host.hxx but it is not compatible with C++17 as it requires C++20 or higher.

My suggestion would be to define a CLAP_HELPERS_UNLIKELY somewhere. But where exactly? In a new header called macros? Or just in host.hxx for now?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add CLAP_HELPERS_UNLIKELY Trinitou/clap-helpers
1 participant
@Trinitou