Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CLAP_HELPERS_UNLIKELY #30

Merged
merged 2 commits into from
Nov 23, 2023
Merged

Add CLAP_HELPERS_UNLIKELY #30

merged 2 commits into from
Nov 23, 2023

Conversation

Trinitou
Copy link
Contributor

resolves #29

@abique
Copy link
Contributor

abique commented Nov 23, 2023

Maybe introduce a macros.hh to put it there?

@Trinitou
Copy link
Contributor Author

Putting the define into host.hxx is the most easy solution. Or do you think it's better to put the define into a separate header (e.g. a new private/macros.h file) to potentially be used by other clap-helpers as well in the future?

@Trinitou
Copy link
Contributor Author

better in a private subfolder or OK like this?

@abique abique merged commit 2cc2f28 into free-audio:main Nov 23, 2023
@abique
Copy link
Contributor

abique commented Nov 23, 2023

Looks good like this.

@Trinitou Trinitou deleted the unlikely branch November 23, 2023 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[[unlikely]] attribute requires C++20
2 participants
@Trinitou @abique