From 5cdb92c2b9b149954ea97534b7af7f42222bc4cd Mon Sep 17 00:00:00 2001
From: Alexandre Bique <bique.alexandre@gmail.com>
Date: Mon, 8 Jan 2024 12:18:10 +0100
Subject: [PATCH] Remove midi mapping extension

---
 ChangeLog.md                           |  5 ++--
 include/clap/clap.h                    |  1 -
 include/clap/ext/draft/midi-mappings.h | 41 --------------------------
 3 files changed, 3 insertions(+), 44 deletions(-)
 delete mode 100644 include/clap/ext/draft/midi-mappings.h

diff --git a/ChangeLog.md b/ChangeLog.md
index c0cba488..0584239a 100644
--- a/ChangeLog.md
+++ b/ChangeLog.md
@@ -14,9 +14,10 @@
 
 Note: we kept the last draft extension ID in order to not break plugins already using it.
 
-## Removed draft extension
+## Removed draft extensions
 
-* `CLAP_EXT_CHECK_FOR_UPDATE` was removed because it wasn't used and it's design needed more thought.
+* `CLAP_EXT_CHECK_FOR_UPDATE` wasn't used and it's design needed more thought.
+* `CLAP_EXT_MIDI_MAPPING` wasn't used. MIDI2 seems to do it better, and the interface wasn't satisfying.
 
 ## Stabilize factory
 * `CLAP_PRESET_DISCOVERY_FACTORY_ID`
diff --git a/include/clap/clap.h b/include/clap/clap.h
index b1d90614..ad95ff33 100644
--- a/include/clap/clap.h
+++ b/include/clap/clap.h
@@ -67,7 +67,6 @@
 
 #include "ext/draft/ambisonic.h"
 #include "ext/draft/cv.h"
-#include "ext/draft/midi-mappings.h"
 #include "ext/draft/resource-directory.h"
 #include "ext/draft/triggers.h"
 #include "ext/draft/tuning.h"
diff --git a/include/clap/ext/draft/midi-mappings.h b/include/clap/ext/draft/midi-mappings.h
deleted file mode 100644
index c584e9d8..00000000
--- a/include/clap/ext/draft/midi-mappings.h
+++ /dev/null
@@ -1,41 +0,0 @@
-#pragma once
-
-#include "../../plugin.h"
-
-static CLAP_CONSTEXPR const char CLAP_EXT_MIDI_MAPPINGS[] = "clap.midi-mappings.draft/0";
-
-#ifdef __cplusplus
-extern "C" {
-#endif
-
-enum {
-   CLAP_MIDI_MAPPING_CC7,
-   CLAP_MIDI_MAPPING_CC14,
-   CLAP_MIDI_MAPPING_RPN,
-   CLAP_MIDI_MAPPING_NRPN,
-};
-typedef int32_t clap_midi_mapping_type;
-
-typedef struct clap_midi_mapping {
-   int32_t channel;
-   int32_t number;
-   clap_id param_id;
-} clap_midi_mapping_t;
-
-typedef struct clap_plugin_midi_mappings {
-   // [main-thread]
-   uint32_t(CLAP_ABI *count)(const clap_plugin_t *plugin);
-
-   // Returns true on success and stores the result into mapping.
-   // [main-thread]
-   bool(CLAP_ABI *get)(const clap_plugin_t *plugin, uint32_t index, clap_midi_mapping_t *mapping);
-} clap_plugin_midi_mappings_t;
-
-typedef struct clap_host_midi_mappings {
-   // [main-thread]
-   void(CLAP_ABI *changed)(const clap_host_t *host);
-} clap_host_midi_mappings_t;
-
-#ifdef __cplusplus
-}
-#endif