NotificationData fix #22
Conversation
danielh1204
changed the title
| @@ -517,8 +517,48 @@ func NFRegisterProcedure( | |||
| } | |||
| } | |||
|
|
|||
| func configureNotifNfProfile(NotifProfile *models.NfProfileNotificationData, nfProfile models.NfProfile) { | |||
There was a problem hiding this comment.
input 都用 pointer
func configureNotifNfProfile(NotifProfile *models.NfProfileNotificationData, nfProfile *models.NfProfile) {
There was a problem hiding this comment.
param NotifProfile rename to notifProfile
danielh1204
force-pushed
the
free5gc#78_fix
branch
from
12fa10b to
c682695
Compare
| @@ -496,7 +496,7 @@ func NFRegisterProcedure( | |||
| nfInstanceUri := locationHeaderValue | |||
|
|
|||
| for _, uri := range uriList { | |||
| problemDetails := SendNFStatusNotify(Notification_event, nfInstanceUri, uri) | |||
| problemDetails := SendNFStatusNotify(Notification_event, nfInstanceUri, uri, nil) | |||
There was a problem hiding this comment.
why fill nil nfProfile here?
There was a problem hiding this comment.
in func SendNFStatusNotify, if the nfprofile is nil, it means i dont have to copy the nfprofile (the paramter) into the notificationData.NfProfile.
according to 3GPP spec
There was a problem hiding this comment.
but your nfProfile is nil and profileChanges is also not present.
There was a problem hiding this comment.
in the case of NFRegisterProcedure, the event attribute's value is REGISTERED when existed returns as false at line 460
There was a problem hiding this comment.
@danielh1204 from sepc, this nfProfile should not be nil. Please fix it.
pr for free5gc/free5gc#78