Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client): downgrade normalize-url to fix Safari issue #42490

Conversation

moT01
Copy link
Member

@moT01 moT01 commented Jun 14, 2021

Checklist:

  • I have read freeCodeCamp's contribution guidelines.
  • My pull request has a descriptive title (not a vague title like Update index.md)
  • My pull request targets the main branch of freeCodeCamp.
  • I have tested these changes either locally on my machine, or GitPod.

Closes #42431

This seems to be the cause of the issues. More context:
sindresorhus/normalize-url#105

It would be nice if another Safari user could test this out.

@gitpod-io
Copy link

gitpod-io bot commented Jun 14, 2021

@github-actions github-actions bot added the platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. label Jun 14, 2021
Copy link
Contributor

@ojeytonwilliams ojeytonwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Further context: https://github.com/sindresorhus/normalize-url#install Also, 4.5.1 has the latest security fix, so it shouldn't be a regression.

Copy link
Member

@raisedadead raisedadead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While you are at this can you please update the renovate config to have this ignored?

@ojeytonwilliams
Copy link
Contributor

We'd want to let it keep creating minor and patch updates, though. https://docs.renovatebot.com/configuration-options/#allowedversions should do the trick.

@ojeytonwilliams
Copy link
Contributor

Also, since the problem is quite frustrating for Safari users, can we get this merged soon?

@ojeytonwilliams ojeytonwilliams enabled auto-merge (squash) June 15, 2021 07:32
@raisedadead
Copy link
Member

Sure go ahead and add the config as you see fit and merge.

@ojeytonwilliams ojeytonwilliams disabled auto-merge June 15, 2021 09:06
@ojeytonwilliams ojeytonwilliams merged commit 3cb174a into freeCodeCamp:main Jun 15, 2021
@moT01 moT01 deleted the fix/downgrade-normalize-url-package-to-fix-Safari-issue branch June 15, 2021 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform: learn UI side of the client application that needs familiarity with React, Gatsby etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Project Description/submission pages do not load on Safari
3 participants