Run basic lint CI against Ubuntu noble / Python 3.12 #7242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not setup to test "Setting up a staging environment using vagrant/libvirt works" so help would be appreciated with that. |
|
Oh also I haven't signed the commits yet, waiting to rebase after the uv PR is merged. |
Just as a baseline to see how far away we are. Some changes: * switch to enchant-2, which is already in focal Refs #7210.
The vendored version of six in pip 21.3 is incompatible with Python 3.12.
cffi 1.14.5 doesn't have prebuilt wheels for Python 3.12. This upgrade was already diff-reviewed: <https://github.com/freedomofpress/securedrop-builder/wiki/cffi-1.14.5-to-1.16.0>.
* molecule-vagrant is outdated and has a constraint blocking pyyaml 6. Note that molecule-vagrant is actually archived in favor of molecule-plugins[vagrant], but leaving that for another time, since it needs molecule 6. * pylint's dependency tree has issues (astroid, wrapt), so upgrade it entirely, which will require some fixes in a follow-up. * pyyaml 6 is used elsewhere and provide prebuild 3.12 wheels.
All of the lints being un-disabled in pylintrc were removed from pylint, most of them only applied to Python 2 code, which is why they were suppressed. Other fixes: * Fix argument name in pretty_bad_protocol (most-likely unused code) * Exempt specialstrings.py from linting, just like ruff. * Raise unreachable exception in pageslayout tests to make pylint happy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
See commit messages for details.
Refs #7210.
Testing
How should the reviewer test this PR?
linttolint (focal)(intentionally not noble, yet)Deployment
Any special considerations for deployment? n/a
Checklist
make lint) and tests (make test) pass in the development containermake -C admin test) pass in the admin development container