Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run basic lint CI against Ubuntu noble / Python 3.12 #7242

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

Run basic lint CI against Ubuntu noble / Python 3.12 #7242

wants to merge 6 commits into from

Commits on Oct 9, 2024

  1. Run basic lint CI against Ubuntu noble / Python 3.12 

    Just as a baseline to see how far away we are.

Some changes:
* switch to enchant-2, which is already in focal

Refs #7210.
    @legoktm
    legoktm committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    8498c67 View commit details
    Browse the repository at this point in the history

  2. Upgrade pyyaml in tests to 6.0.1

    @legoktm
    legoktm committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    4b65a86 View commit details
    Browse the repository at this point in the history

  3. Upgrade pip to 24.2 

    The vendored version of six in pip 21.3 is incompatible with Python
3.12.
    @legoktm
    legoktm committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    a4a656b View commit details
    Browse the repository at this point in the history

  4. Upgrade cffi to 1.16.0 

    cffi 1.14.5 doesn't have prebuilt wheels for Python 3.12.

This upgrade was already diff-reviewed:
<https://github.com/freedomofpress/securedrop-builder/wiki/cffi-1.14.5-to-1.16.0>.
    @legoktm
    legoktm committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    36f0cdc View commit details
    Browse the repository at this point in the history

  5. Upgrade development dependencies for Python 3.12 (noble) compat 

    * molecule-vagrant is outdated and has a constraint blocking pyyaml 6.
  Note that molecule-vagrant is actually archived in favor of
molecule-plugins[vagrant], but leaving that for another time, since it
  needs molecule 6.
* pylint's dependency tree has issues (astroid, wrapt), so upgrade it
  entirely, which will require some fixes in a follow-up.
* pyyaml 6 is used elsewhere and provide prebuild 3.12 wheels.
    @legoktm
    legoktm committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    00aea42 View commit details
    Browse the repository at this point in the history

  6. Fix pylint warnings 

    All of the lints being un-disabled in pylintrc were removed from pylint,
most of them only applied to Python 2 code, which is why they were
suppressed.

Other fixes:

* Fix argument name in pretty_bad_protocol (most-likely unused code)
* Exempt specialstrings.py from linting, just like ruff.
* Raise unreachable exception in pageslayout tests to make pylint happy
    @legoktm
    legoktm committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    7ecc53a View commit details
    Browse the repository at this point in the history