Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return a dataclass from geqdsk.read #23

Merged
merged 6 commits into from
Sep 23, 2024
Merged

Return a dataclass from geqdsk.read #23

merged 6 commits into from
Sep 23, 2024

Conversation

ZedThree
Copy link
Collaborator

Closes #17

LiamPattinson
LiamPattinson requested changes Sep 21, 2024
View reviewed changes
Copy link
Collaborator

@LiamPattinson LiamPattinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found a few minor issues, but generally I think it's a big improvement. The __setitem__ bug and minimum Python version need addressing, but otherwise looks good.

freeqdsk/geqdsk.py Show resolved Hide resolved
freeqdsk/geqdsk.py Outdated Show resolved Hide resolved
freeqdsk/geqdsk.py Outdated Show resolved Hide resolved
freeqdsk/geqdsk.py Outdated Show resolved Hide resolved
@ZedThree ZedThree merged commit 72cf422 into main Sep 23, 2024
2 checks passed
@ZedThree ZedThree deleted the dataclass branch September 23, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LiamPattinson LiamPattinson LiamPattinson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use class for data instead of/as well as dict
2 participants
@ZedThree @LiamPattinson