-
-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
4845 pray-and-pray revisions pt. 4 #4956
base: main
Are you sure you want to change the base?
Conversation
… to break up requests into waiting and granted tables
for more information, see https://pre-commit.ci
@mlissner I'm getting tripped up by some tests that may be flaky. I didn't touch disclosures but their tests started failing now. |
There's a flaky test for some reason. It'll get fixed shortly, you can ignore. If that's all there is holding this up, let me know and we'll review anyway. |
This PR may be ready. I say "may" because I'm having issues rebuilding the docker containers after tailwind was added, so I can't actually see what the frontend looks like. That being said, no germane tests failed earlier, so I suspect nothing is seriously broken with these changes. |
Hey @v-anne!, could you please describe the error messages or unexpected behavior you're encountering when trying to build the docker containers? Have you tried running |
@ERosendo, there aren't any error messages per se, but the containers are hanging indefinitely at various stages. For example, this was pending for almost 25 minutes:
I suspect it may be because of my computer's age (5 years old), but I'm not completely sure. |
That sort of sounds like it's just the last log line, and nothing had to be printed. Is it actually stuck? |
Making further revisions to the pray-and-pay feature, as outlined in #4845.
Changes include: