Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4845 pray-and-pray revisions pt. 4 #4956

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

v-anne
Copy link
Contributor

@v-anne v-anne commented Jan 23, 2025

Making further revisions to the pray-and-pay feature, as outlined in #4845.

Changes include:

  • Adding pagination to the community leaderboard
  • Breaking the user prayers page into two tables, one of pending requests and one of granted ones

@v-anne
Copy link
Contributor Author

v-anne commented Jan 24, 2025

@mlissner I'm getting tripped up by some tests that may be flaky. I didn't touch disclosures but their tests started failing now.

@mlissner
Copy link
Member

There's a flaky test for some reason. It'll get fixed shortly, you can ignore. If that's all there is holding this up, let me know and we'll review anyway.

@v-anne
Copy link
Contributor Author

v-anne commented Jan 24, 2025

This PR may be ready. I say "may" because I'm having issues rebuilding the docker containers after tailwind was added, so I can't actually see what the frontend looks like. That being said, no germane tests failed earlier, so I suspect nothing is seriously broken with these changes.

@ERosendo
Copy link
Contributor

because I'm having issues rebuilding the docker containers after tailwind was added, so I can't actually see what the frontend looks like.

Hey @v-anne!, could you please describe the error messages or unexpected behavior you're encountering when trying to build the docker containers? Have you tried running docker compose up -d --build?

@v-anne
Copy link
Contributor Author

v-anne commented Jan 24, 2025

@ERosendo, there aren't any error messages per se, but the containers are hanging indefinitely at various stages.

For example, this was pending for almost 25 minutes:

cl-postgres | 2025-01-24 16:31:23.842 UTC [22] LOG: checkpoint complete: wrote 3 buffers (0.0%); 0 WAL file(s) added, 0 removed, 0 recycled; write=0.003 s, sync=0.002 s, total=0.011 s; sync files=2, longest=0.001 s, average=0.001 s; distance=0 kB, estimate=0 kB

I suspect it may be because of my computer's age (5 years old), but I'm not completely sure.

@mlissner
Copy link
Member

That sort of sounds like it's just the last log line, and nothing had to be printed. Is it actually stuck?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants