DR-2672 - Dummy stub for client setinfo

freshworks · Nov 4, 2024 · 3f95719 · 3f95719
1 parent f435e3a
commit 3f95719
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/source/extensions/filters/network/common/redis/supported_commands.h b/source/extensions/filters/network/common/redis/supported_commands.h
@@ -113,7 +113,7 @@ struct SupportedCommands {
   * @return client sub commands thats supported 
   */
   static const absl::flat_hash_set<std::string>& clientSubCommands() {
-    CONSTRUCT_ON_FIRST_USE(absl::flat_hash_set<std::string>, "getname","setname");
+    CONSTRUCT_ON_FIRST_USE(absl::flat_hash_set<std::string>, "getname","setname", "setinfo");
   }
 
     /**

diff --git a/source/extensions/filters/network/redis_proxy/command_splitter_impl.cc b/source/extensions/filters/network/redis_proxy/command_splitter_impl.cc
@@ -2007,6 +2007,9 @@ SplitRequestPtr InstanceImpl::makeRequest(Common::Redis::RespValuePtr&& request,
         ClientResp->type(Common::Redis::RespType::BulkString);
         ClientResp->asString() = callbacks.getClientname();
       }
+    }else if (sub_command == "setinfo") {
+      ClientResp->type(Common::Redis::RespType::SimpleString);
+      ClientResp->asString() = "OK";
     }
     callbacks.onResponse(std::move(ClientResp));
     return nullptr;