Fixing iteration related issue in scan command

freshworks · Oct 8, 2024 · 4e715cb · 4e715cb
1 parent 3742078
commit 4e715cb
Showing 1 changed file with 10 additions and 9 deletions.
diff --git a/source/extensions/filters/network/redis_proxy/command_splitter_impl.cc b/source/extensions/filters/network/redis_proxy/command_splitter_impl.cc
@@ -1375,15 +1375,16 @@ SplitRequestPtr ScanRequest::create(Router& router, Common::Redis::RespValuePtr&
     addBulkString(requestArray, request_ptr->resp_obj_count_);
   }
 
-  std::string request_str;
-  for (const auto& element : requestArray.asArray()) {
-    if (element.type() == Common::Redis::RespType::BulkString) {
-      request_str += element.asString() + " ";
-    }
-  }
-
-  // Log the constructed request array
-  ENVOY_LOG(debug, "Constructed SCAN request: {}", request_str);
+  // Un comment this to log the constructed request array
+  // std::string request_str;
+  // for (const auto& element : requestArray.asArray()) {
+  //   if (element.type() == Common::Redis::RespType::BulkString) {
+  //     request_str += element.asString() + " ";
+  //   }
+  // }
+
+  // // Log the constructed request array
+  // ENVOY_LOG(debug, "Constructed SCAN request: {}", request_str);
 
   // caching the request and route for making child request from response
   request_ptr->request_ = requestArray;