DR-2555 DR-2553 Fixing invalid shard index - bug #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dinesh-murugiah
requested changes
Oct 7, 2024
pratheep-kumar
changed the title
pratheep-kumar
changed the title
dinesh-murugiah
requested changes
Oct 8, 2024
source/extensions/filters/network/redis_proxy/command_splitter_impl.cc
Outdated
Show resolved
Hide resolved
|
|
||
| addBulkString(requestArray, arg); | ||
|
|
||
| if (arg == "count") { |
There was a problem hiding this comment.
can we have it as part of same validation function
pratheep-kumar
added a commit
that referenced
this pull request
Oct 9, 2024
* Fixing invalid shard index - bug * fix * Fixing iteration related issue in scan command * Fixing iteration related issue in scan command * Fixing iteration related issue in scan command * Fixing iteration related issue in scan command * fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]