Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove assert and add logs when response received after request flushed #42

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

dinesh-murugiah
Copy link
Collaborator

In production we have seen scenarios where the response is received while there was no pending request tied to it
this could happen in very corner cases of race condition , where a connection close event and the response handling is triggered at the same time
The work arround is to remove the assert and replace it with error logs to see what response is received and adding variables to check if it was followed by request flushing

Copy link
Collaborator

@pratheep-kumar pratheep-kumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@dinesh-murugiah dinesh-murugiah merged commit 4db4a88 into v1.28.0-dbaas Nov 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants