fix in scan command and support for redis insights #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dinesh-murugiah
requested review from
samof76,
pratheep-kumar,
Sasidharan-Gopal and
suryadeepr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when parsing the arguments of scan command and checking the validity of the arguments
the arguments were not converted to lower case before doing any operations to make it case insentive
this resulted in failure when giving MATCH and COUNT argument in caps
this is a not a critical problem as it will usually be a manual command , But Tools which use this may fail
This also failed redis insights to work properly , This fix solves this