Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a v2 example_package() #258

Merged
merged 34 commits into from
Aug 29, 2024
Merged

Create a v2 example_package() #258

merged 34 commits into from
Aug 29, 2024

Conversation

sannegovaert
Copy link
Contributor

@sannegovaert sannegovaert commented Aug 27, 2024

fix #249

This comment was marked as outdated.

@peterdesmet
Copy link
Member

Are you making a v2 example_package?

Depends if you want to try yourself. :-) The guiding document is https://datapackage.org/overview/changelog/

@sannegovaert
Copy link
Contributor Author

Are you making a v2 example_package?

Depends if you want to try yourself. :-) The guiding document is https://datapackage.org/overview/changelog/

I will try! :-)

R/example_package.R Outdated Show resolved Hide resolved
@sannegovaert
Copy link
Contributor Author

@peterdesmet Not sure, does foreignKey.reference.resource need to be updated?
frictionlessdata/datapackage-v2-draft#29

@peterdesmet
Copy link
Member

Yes please, since self-referencing is simpler now.

@sannegovaert sannegovaert marked this pull request as ready for review August 28, 2024 08:30
Copy link
Member

@peterdesmet peterdesmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This will be very useful for tests.

I have updated example_package() to just default to reading from v1 when an unsupported version is supplied, rather than giving an error. This is a little bit less informative to users, but I plan to have print() return the version as found in datapackage.json + we don't have to update supported_versions in different places.

@peterdesmet peterdesmet merged commit d5e723e into main Aug 29, 2024
7 of 8 checks passed
@peterdesmet peterdesmet deleted the v2-example_package branch August 29, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a v2 example_package
2 participants