Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: warn if selecting unrelated file names for compare and merge #3

Open
dictionarymouse opened this issue Apr 6, 2023 · 1 comment

Comments

@dictionarymouse
Copy link

I accidentally clicked on the wrong file to compare with. The proposed changes seemed a little odd, but I didn't fully notice until the end when I was offered a chance to delete the identical files. (Thank you for that confirmation warning.) I didn't discard and was able to do some cleanup.

I suggest adding a notification if the file selected as a conflict isn't similar.

Example:
If the original file name is "File-A.md" and the second file is "File-A sync-conflict.md" the comparison would proceed.
If File-A.md and XYZ.md are selected, a notification would appear, such as:
"Please note the file names, File-A.md and XYZ.md do not match, are you sure you wish to proceed?"
Especially since one cannot tell (yet) after the fact which files are being compared, this could be an important warning.

@friebetill
Copy link
Owner

Thanks for the suggestion! With the latest update, the tab title shows which files are compared. I think that makes it a bit better. However, this does not completely solve the problem. Personally I think it's more of an edge case, but if multiple people have the issue, minimum 10 likes for this issue, then I will implement the warning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants