-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to Typescript #720
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also, allow tracing the http requests
drewvolz
previously approved these changes
May 8, 2024
hawkrives
force-pushed
the
hawken/tsc-on-js
branch
from
May 8, 2024 13:06
534664d
to
0016f28
Compare
drewvolz
previously approved these changes
May 20, 2024
drewvolz
reviewed
May 24, 2024
drewvolz
previously approved these changes
May 25, 2024
drewvolz
previously approved these changes
May 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done @hawkrives! 🥳
drewvolz
approved these changes
May 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's finally time to migrate this project to Typescript. While it's been nice not having any build step, I've come to yearn for the feeling of safety that I get from having
tsc
close at hand. Anyway!.ts
extensionsava
(has auto-TS stuff built in)typed-query-selector
for some basic querySelector checking (even works automatically with JSDOM!)prettier.printWidth
to 100 – typescript likes a little more horizontal freedom