Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Typescript #720

Merged
merged 57 commits into from
May 25, 2024
Merged

Migrate to Typescript #720

merged 57 commits into from
May 25, 2024

Conversation

hawkrives
Copy link
Member

@hawkrives hawkrives commented May 8, 2024

It's finally time to migrate this project to Typescript. While it's been nice not having any build step, I've come to yearn for the feeling of safety that I get from having tsc close at hand. Anyway!

  • Migrate all files to .ts extensions
  • Add types, where appropriate
  • Migrate test runner to ava (has auto-TS stuff built in)
  • Add typed-query-selector for some basic querySelector checking (even works automatically with JSDOM!)
  • Added a few more Zod schemæ
  • Expand prettier.printWidth to 100 – typescript likes a little more horizontal freedom
  • Perform some code cleanups

drewvolz
drewvolz previously approved these changes May 8, 2024
source/student-orgs/presence.ts Show resolved Hide resolved
source/ccc-lib/http.ts Show resolved Hide resolved
@hawkrives hawkrives requested a review from rye as a code owner May 12, 2024 13:29
drewvolz
drewvolz previously approved these changes May 20, 2024
source/student-orgs/presence.ts Outdated Show resolved Hide resolved
source/student-orgs/presence.ts Outdated Show resolved Hide resolved
drewvolz
drewvolz previously approved these changes May 25, 2024
drewvolz
drewvolz previously approved these changes May 25, 2024
Copy link
Member

@drewvolz drewvolz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done @hawkrives! 🥳

@hawkrives hawkrives merged commit a888496 into master May 25, 2024
9 checks passed
@hawkrives hawkrives deleted the hawken/tsc-on-js branch May 25, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants