Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support LLVM backend #171
Support LLVM backend #171
Changes from 65 commits
e5de4b1
490766b
c312c58
3e90edc
ef1879c
eca3d05
fcc5838
2975b36
c3603aa
9e85f46
c903cc9
df0f59a
2d46738
af47ebd
ada573d
690db76
af5678e
b4a9c16
4b250f1
e983617
7ccc800
bc5c7a5
6bfb6d0
65b7af0
563fba5
fc9f7d4
158ac6e
07706ec
c93394b
fd78532
ceede3e
f5aecb6
2dfce85
98a05f3
99b7073
5de045d
4730d88
d7c92a8
e304306
6cc3e40
70f5a48
afef598
605ad92
0e58922
0e2ed54
5667659
c5c10d8
25d215f
65a6b01
ff27229
28d9087
9f5ee56
4061c19
eca43dd
4b8a5bd
6c9f9c9
09edb47
d648869
4355ca5
7d70f29
3b87b34
2599d8a
fdd8c90
9e5384a
7886b4d
3099ea2
4e1b634
f598de2
1f8ca0a
aa98013
e22a126
89b08d1
6b89405
49d3ab0
93dd326
cd17d35
bc6e894
015682e
3fa5700
a2ce9e0
9c0088f
6e50cce
c030086
f212231
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any specific reason for storing these data members as unique pointers instead of values?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I used unique pointers to store them is because these data members must be the same when generating LLVM IR. Or else, the builder will not generate the correct LLVM IR under the correct
module_
andcontext_
. Any suggestions?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They seem to be passed by reference when used, meaning they are not going to be copied. Furthermore, I believe these classes are not copyable, thus already unique within the code generator.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unique pointers removed!