Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the project great again #197

Open
5 of 9 tasks
NadezhdaShosheva opened this issue Nov 9, 2021 · 2 comments
Open
5 of 9 tasks

Make the project great again #197

NadezhdaShosheva opened this issue Nov 9, 2021 · 2 comments

Comments

@NadezhdaShosheva
Copy link

NadezhdaShosheva commented Nov 9, 2021

  • Fix eslint warnings, renew husky pre-commit hook, add more strict rules
  • Prettier and eslint should use the same rules
  • Yarn lint fix - command in package.json that just makes it all better
  • Use types, not interface -> switch to types everywhere
  • Confirm the naming of types.. T?
  • рассмотреть общие типы и вынести на верхний уровень
  • Discuss the DDD approach
  • Handling errors - GraphQL, how to write query requests - discuss hook design
  • Get rid of the ErrorDecorator
@diana-fazlieva
Copy link

Комментарий от @Dmitriy-Alekseenko: "А почему type, а не interface? Потому что если навести на interface то не всплывает информация из какие элементов этот interface состоит?"

@DmitriyFirsov
Copy link
Contributor

Кмк, с типами проще работать когда какие-то сложные манипуляции проводишь
а так особой разницы нет

@diana-fazlieva diana-fazlieva changed the title Сделать хорошо в проекте Make the project great again Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants