Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't put a space before a prefix operator, unless we have to. #3134

Merged
merged 4 commits into from
Nov 2, 2024

Conversation

nojaf
Copy link
Contributor

@nojaf nojaf commented Oct 29, 2024

Fixes #3131

  • Moved some related tests around to new testfile.
  • Targeting v7.0 because it can lead to a git diff when folks would update.

Could you review this one for me @brianrourkeboll? Just to make sure I didn't miss anything.
@dawedawe please review the Fantomas' side of things.

Thanks all!

@nojaf nojaf requested a review from dawedawe October 29, 2024 09:38
@nojaf nojaf linked an issue Oct 29, 2024 that may be closed by this pull request
4 tasks
src/Fantomas.Core.Tests/PrefixTests.fs Outdated Show resolved Hide resolved
src/Fantomas.Core.Tests/PrefixTests.fs Outdated Show resolved Hide resolved
src/Fantomas.Core.Tests/PrefixTests.fs Show resolved Hide resolved
src/Fantomas.Core.Tests/PrefixTests.fs Outdated Show resolved Hide resolved
src/Fantomas.Core/CodePrinter.fs Outdated Show resolved Hide resolved
"86u"
"86ul"
"0x00002D3Fun"
"86UL"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"86UL"
"86UL"
"1<m>

Or in a separate test if you like.

@nojaf nojaf merged commit 75e8474 into fsprojects:v7.0 Nov 2, 2024
5 checks passed
@nojaf nojaf mentioned this pull request Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unary operators: inconsistent formatting when arg is literal vs variable
3 participants