Update core.py #849
Open
Update core.py #849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor the code to improve mime type guessing by utilizing the destination file instead of relying on the source file. This change was prompted by the inconvenience of having uncompressed Minio objects when the source was a .tmp file that I would subsequently copy to .txt or .csv format.
I´m not really seeing the use case, but seems harmless enough. Co-authored-by: Martin Durant <martindurant@users.noreply.github.com>
|
Can we have a test for this please, now with an inferable path name for local, remote, and both. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the code to improve mime type guessing by utilizing the destination file instead of relying on the source file. This change was prompted by the inconvenience of having uncompressed Minio objects when the source was a .tmp file that I would subsequently copy to .txt or .csv format.
Based on the observation, it seems there shouldn't be any drawbacks to this change, as the scenarios considered are:
The question arises: Does anyone currently utilize the scenario where local files have known extensions while remote files have unknown extensions?