[refactor] Parametrize builder to make DRY

tests/sphinx_new_tab_link/test_build_dirhtml.py

@@ -42,16 +42,3 @@ def test_should_open_new_tab(
     assert "external" in ref["class"]
     assert ref["target"] == "_blank"
     assert ref["rel"] == ["noopener", "noreferrer"]
-
-
-@pytest.mark.sphinx("dirhtml", testroot="default")
-def test_internal_link_should_not_open_new_tab(app: SphinxTestApp):
-    app.build()
-    html = (app.outdir / "index.html").read_text()
-    soup = BeautifulSoup(html, "html.parser")
-    references = soup.find_all("a", {"class": "reference"})
-
-    ref = references[-1]
-    assert "internal" in ref["class"]
-    assert "target" not in ref.attrs
-    assert "rel" not in ref.attrs

tests/sphinx_new_tab_link/test_build_html.py

@@ -42,16 +42,3 @@ def test_should_open_new_tab(
     assert "external" in ref["class"]
     assert ref["target"] == "_blank"
     assert ref["rel"] == ["noopener", "noreferrer"]
-
-
-@pytest.mark.sphinx("html", testroot="default")
-def test_internal_link_should_not_open_new_tab(app: SphinxTestApp):
-    app.build()
-    html = (app.outdir / "index.html").read_text()
-    soup = BeautifulSoup(html, "html.parser")
-    references = soup.find_all("a", {"class": "reference"})
-
-    ref = references[-1]
-    assert "internal" in ref["class"]
-    assert "target" not in ref.attrs
-    assert "rel" not in ref.attrs

tests/sphinx_new_tab_link/test_build_singlehtml.py

@@ -42,16 +42,3 @@ def test_should_open_new_tab(
     assert "external" in ref["class"]
     assert ref["target"] == "_blank"
     assert ref["rel"] == ["noopener", "noreferrer"]
-
-
-@pytest.mark.sphinx("singlehtml", testroot="default")
-def test_internal_link_should_not_open_new_tab(app: SphinxTestApp):
-    app.build()
-    html = (app.outdir / "index.html").read_text()
-    soup = BeautifulSoup(html, "html.parser")
-    references = soup.find_all("a", {"class": "reference"})
-
-    ref = references[-1]
-    assert "internal" in ref["class"]
-    assert "target" not in ref.attrs
-    assert "rel" not in ref.attrs

tests/test_sphinx_new_tab_link.py

@@ -0,0 +1,27 @@
+import shutil
+
+import pytest
+from bs4 import BeautifulSoup
+
+
+@pytest.mark.parametrize("builder", ["html", "singlehtml", "dirhtml"])
+def test_internal_link_should_not_open_new_tab(
+    make_app, sphinx_test_tempdir: str, rootdir: str, builder: str
+):
+    testroot = "default"
+    srcdir = sphinx_test_tempdir / testroot
+    if not srcdir.exists():
+        testroot_path = rootdir / f"test-{testroot}"
+        shutil.copytree(testroot_path, srcdir)
+
+    app = make_app(builder, srcdir=srcdir)
+    app.build()
+
+    html = (app.outdir / "index.html").read_text()
+    soup = BeautifulSoup(html, "html.parser")
+    references = soup.find_all("a", {"class": "reference"})
+
+    ref = references[-1]
+    assert "internal" in ref["class"]
+    assert "target" not in ref.attrs
+    assert "rel" not in ref.attrs