Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prop-types should be a proper dependency #525

Open
magnattic opened this issue Oct 12, 2021 · 0 comments
Open

prop-types should be a proper dependency #525

magnattic opened this issue Oct 12, 2021 · 0 comments

Comments

@magnattic
Copy link

Right now prop-types is a devDependency even though it is needed by the package to run properly. This breaks the package when used with yarn 3 and plug'n'play, because prop-types will not be installed with google-maps-react and consecutively not accessible:

ModuleNotFoundError: Module not found: Error: Can't resolve 'prop-types' in '/srv/.yarn/virtual/google-maps-react-virtual-a5292661de/0/cache/google-maps-react-npm-2.0.6-79c5177d9a-cf5120d6ff.zip/node_modules/google-maps-react/dist/components'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@magnattic