Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[contributors]: Added the scripts to be able to recognize contributors #31

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mog-rn
Copy link

@mog-rn mog-rn commented Oct 6, 2022

No description provided.

@mog-rn
Copy link
Author

mog-rn commented Oct 6, 2022

Fixes #24

@funbeedev funbeedev linked an issue Oct 7, 2022 that may be closed by this pull request
Copy link
Owner

@funbeedev funbeedev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are needed to properly show contributors of the repo.

@@ -1,4 +1,7 @@
<img src="https://inspirezone.tech/wp-content/uploads/2022/10/Accepting-Contributions-for-Hacktoberfest2022.png" width="300">
<!-- ALL-CONTRIBUTORS-BADGE:START - Do not remove or modify this section -->
[![All Contributors](https://img.shields.io/badge/all_contributors-0-orange.svg?style=flat-square)](#contributors-)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MogakaMo This is not rendering correctly on the README. Can you fix please.

@@ -53,3 +56,16 @@ This will allow you to view the site on a web browser at `http://localhost:8000/
Make your changes and test in your local environment. Then submit a PR to this repo.

### ❓ Got a question, something to discuss or just curious to learn more about this project? Check out the [DISCUSSION](../../discussions) section.

## Contributors ✨
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MogakaMo I'm not able to see the list of contributors to the repo following the change you made. Can you please check what is required to correctly use the allcontributors feature? You can read the docs at: https://allcontributors.org/docs/en/overview
Thanks for your efforts!

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not able to get all the contributors on the. README.md file since I do not have write access on the repo but I have set a script that I had set to help you add it since you are the one who has write access

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@funbeedev I will be sharing the command to be able to do so.
That section on the readme for contributors is updated automatically so it should not be modified manually

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MogakaMo Please share the command or make the updates so the README will show the contributors. Thanks!

Copy link
Author

@mog-rn mog-rn Oct 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

npm contributors:add <github-username> <role>

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@funbeedev you can use the command above to add a contributor. For now, you can do it from this pr but as soon as you merge it you can do it from the main branch.
Incase of anthing just tag me

@funbeedev funbeedev added hacktoberfest-accepted change required before merge! Make the change requested in the PR comment labels Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change required before merge! Make the change requested in the PR comment hacktoberfest-accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Recognise all contributors in README
2 participants