Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash when SENTRY_ENABLED is undefined #340

Conversation

staticfox
Copy link
Collaborator

Otherwise eval_bool is called on x where x is None, leading to None.lower() which causes:

AttributeError: 'NoneType' object has no attribute 'lower'

Copy link
Member

@rechner rechner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🍏

@staticfox
Copy link
Collaborator Author

Looks like CI is failing for an unrelated reason:

dpkg: dependency problems prevent configuration of wkhtmltox:
 wkhtmltox depends on libssl1.1; however:
  Package libssl1.1 is not installed.

dpkg: error processing package wkhtmltox (--install):
 dependency problems - leaving unconfigured
Processing triggers for man-db (2.12.0-4build2) ...
Errors were encountered while processing:
 wkhtmltox
Error: Process completed with exit code 1.

@rechner
Copy link
Member

rechner commented Dec 29, 2024

Hmmmm, yeah looks like Actions has started rolling out 24.04 for the ubuntu-latest tag this month. On the horizon is eventually replacing wkhtmltox all together but for now I'll just pin our workflows to use 22.04.

@rechner
Copy link
Member

rechner commented Dec 29, 2024

@staticfox go ahead and sync your branch and you should be good

Otherwise eval_bool is called on x where x is None, leading to
None.lower() which causes:

AttributeError: 'NoneType' object has no attribute 'lower'
@staticfox staticfox force-pushed the bugfix/settings-docker-sentry-enabled-crashfix branch from 5b8180e to d72b100 Compare December 29, 2024 23:04
@staticfox
Copy link
Collaborator Author

rebased from the production branch

@staticfox
Copy link
Collaborator Author

@staticfox
Copy link
Collaborator Author

Actually, it might be because of

With the exception of GITHUB_TOKEN, secrets are not passed to the runner when a workflow is triggered from a forked repository.

Let me push the branch here then change this MR's branch source to the repo's branch.

@staticfox
Copy link
Collaborator Author

Actually, since I can't change the source branch, I'll open a new PR with the source branch set to a fresh branch from this repo with a different commit hash than the one from my fork.

@staticfox staticfox closed this Dec 29, 2024
@staticfox staticfox deleted the bugfix/settings-docker-sentry-enabled-crashfix branch December 30, 2024 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants