-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix crash when SENTRY_ENABLED is undefined #340
Fix crash when SENTRY_ENABLED is undefined #340
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! 🍏
Looks like CI is failing for an unrelated reason:
|
Hmmmm, yeah looks like Actions has started rolling out 24.04 for the |
@staticfox go ahead and sync your branch and you should be good |
Otherwise eval_bool is called on x where x is None, leading to None.lower() which causes: AttributeError: 'NoneType' object has no attribute 'lower'
5b8180e
to
d72b100
Compare
rebased from the production branch |
Trying to find GitHub Actions documentation - https://github.com/furthemore/APIS/actions/runs/12539416559/job/34965679066?pr=340#step:6:13 all the CI secrets are blanked out, as compared to https://github.com/furthemore/APIS/actions/runs/12539402569/job/34965503559#step:6:12 |
Actually, it might be because of
Let me push the branch here then change this MR's branch source to the repo's branch. |
Actually, since I can't change the source branch, I'll open a new PR with the source branch set to a fresh branch from this repo with a different commit hash than the one from my fork. |
Otherwise eval_bool is called on x where x is None, leading to None.lower() which causes:
AttributeError: 'NoneType' object has no attribute 'lower'