Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mock out calls to wkhtmltopdf in tests #343

Merged
merged 1 commit into from
Dec 30, 2024
Merged

Mock out calls to wkhtmltopdf in tests #343

merged 1 commit into from
Dec 30, 2024

Conversation

staticfox
Copy link
Collaborator

This mocks out calls to the wkhtmltopdf binary on the system and instead asserts that the binary was called with the correct filename.

@staticfox
Mock out calls to wkhtmltopdf in tests
5e60487 
This mocks out calls to the wkhtmltopdf binary on the system
and instead asserts that the binary was called with the correct
filename.
@staticfox staticfox requested a review from rechner December 30, 2024 07:16
rechner
rechner approved these changes Dec 30, 2024
View reviewed changes
Copy link
Member

@rechner rechner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 very nice

@staticfox staticfox merged commit 9ca03d2 into production Dec 30, 2024
3 checks passed
@staticfox staticfox deleted the tests/mock-out-calls-to-wkhtmltopdf branch December 30, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rechner rechner rechner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@staticfox @rechner