Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom lint rules #66

Open
matejsemancik opened this issue Oct 15, 2019 · 1 comment
Open

Add custom lint rules #66

matejsemancik opened this issue Oct 15, 2019 · 1 comment

Comments

@matejsemancik
Copy link
Member

Would be nice to have custom lint rules for mvvm module (eg. wrong event naming) and interactors module (eg. warning that you forgot to use init method, or warning that you are passing Pair as execute argument in future). Any opinions on this?

I already have implemented MVVM event naming rule, and need ideas for more, if that makes sense to you.

@skywall
Copy link
Contributor

skywall commented Nov 20, 2019

Prohibit multiple usage of same lambda in InteractorConfig:

interactor.execute(Unit) {
    onError {}
    onError {}
}

Check order of lambdas in InteractorConfig:

OK
interactor.execute(Unit) {
    onSuccess {}
    onError {}
}

BAD
interactor.execute(Unit) {
    onError {}
    onSuccess {}
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants