[RPD-259] Refactor build_state_from_terraform_output within matcha_state.py to use objects defined within matcha_state.py
#190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swells2020
commented
Aug 9, 2023
swells2020
changed the title
build_state_from_terraform_output within matcha_state.py to use objects defined within matcha_state.py
Christopher-Norman
requested changes
Aug 11, 2023
KirsoppJ
approved these changes
Aug 11, 2023
src/matcha_ml/state/matcha_state.py
Outdated
|
|
||
| component = matcha_state.get_component(resource_type.name) | ||
|
|
||
| if component: |
There was a problem hiding this comment.
nit: might be a bit easier to read if this was an if component is not None
7 tasks
JonoCX
added a commit
that referenced
this pull request
Aug 15, 2023
* [RPD-287] ZenML version inference for zenserver (#180) * various changes * change variable names to make things more clear * shubham's comment * test for latest * update existing tests * update existing tests * shubham latest comment * add gitflow notation branches to ci (#183) * remove old, commented out code * [RPD-260] Add an object to handle the `matcha.config.json` file. (#184) * adds logic and tests for matcha config module * updates docstrings * adds tests and implements config object throughout matcha * updated for pr comments * updates docstring * fixes ci * updates for comments * [RPD-249] Refactor `analytics_service` to simplify tracking decorator (#181) * refactor analytics service * adds tests and updates for comments * updates tests * updates for comments * extracts _get_state_uuid logic into private function * removes old _get_state_uuid logic * updates _execute_analytics_event_function * extracts _time_event logic * adds _post_event logic * adds tests * adds dataclass * updates tests * [RPD-236] Improved approach to check ignored folder when uploading and downloading (#186) * [RPD-250] Move `_show_terraform_outputs()` into `provision` (#188) * updates core and azure_runner * adds test * updated for comments * updates test fixtures * [RPD-259] Refactor `build_state_from_terraform_output` within `matcha_state.py` to use objects defined within matcha_state.py (#190) * updates build_state_from_terraform_outputs * updates for comments * fixes tests * removes print statement * updates get_component * updates get_component * updates for comments * [RPD-290] Update MatchaConfig object to not throw an error when a matching property/component is not found (#192) --------- Co-authored-by: KirsoppJ <40233184+KirsoppJ@users.noreply.github.com> Co-authored-by: Callum Wells <68609181+swells2020@users.noreply.github.com>
Christopher-Norman
deleted the
RPD-259-refactor-build_state_from_terraform_output
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the
build_state_from_terraform_outputmethod to make use of the custom classes within thematcha_state.pymodule.Previously, the
build_state_from_terraform_outputmethod made use of the_parse_terraform_outpututility function to build a dictionary representation of state. This dictionary was then converted into aMatchaStateobject using thefrom_dictmethod in the MatchaState class.In this new implementation, the
MatchaStateobject is built using the relevant classes representing underlying resources, properties and components.This PR also updates the
get_componentmethod of the MatchaStateService by moving it to theMatchaStateobject and adding an ability for the method to returnNone. Changes have been made to the broader matcha codebase to account for this change.Checklist
Please ensure you have done the following:
Type of change
Tick all those that apply: