Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FvwmButtons listens for incoming TCP connections #1029

Closed
vladrich opened this issue May 29, 2024 · 2 comments · Fixed by #1030
Closed

FvwmButtons listens for incoming TCP connections #1029

vladrich opened this issue May 29, 2024 · 2 comments · Fixed by #1030
Labels
type:bug Something's broken!

Comments

@vladrich
Copy link
Contributor

Hello,

I cannot find a dedicated security contact, so I am posting this here.

FvwmButtons listens for incoming TCP connections from any host, which is a major security risk.

# netstat -ltpv 
Active Internet connections (only servers)
Proto Recv-Q Send-Q Local Address           Foreign Address         State       PID/Program name    
tcp        0      0 0.0.0.0:38221           0.0.0.0:*               LISTEN      15701/FvwmButtons   
tcp6       0      0 [::]:42179              [::]:*                  LISTEN      15701/FvwmButtons   

Running on Linux x86_64.

As far as I can see, the port is opened here:

fvwm3/libs/fsm.c

Line 1046 in 5d6c045

if (!FIceListenForConnections (

Others seem to be mitigating the problem by limiting communication to UNIX sockets via calling _IceTransNoListen ("tcp")

Can FVWM do the same?

Thanks,
V.

@vladrich vladrich added the type:bug Something's broken! label May 29, 2024
@ThomasAdam
Copy link
Member

Hi @vladrich

This is a very old bug.

Open a PR to fix this, please.

@vladrich
Copy link
Contributor Author

I've tried with #1030 now. Please check carefully - I am not fluent at C programming. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something's broken!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants