FvwmPager doesn't update current desk durning initialization #1122
Comments
|
Can you share the configuration and how you launched the problematic pager? |
The pager shows Desk 0 |
|
|
|
Well in my testing, I guess two stars, |
|
It seems the issue is with fvwm3 1.1.1 (1.1.0-130-g27ffd68a) |
|
I still cannot produce the issue with FvwmPager not updating the current desk properly. But the commands you are issuing are mostly nonsense (though it does appear they are broken I'll look into that). But "Three arguments specify a relative desk and the minimum and maximum of the allowable range." So you are stating move |
|
Maybe read my full post, and notice how no example on the wiki uses the min and max desktop to be the same. Though I fixed the bug that existed due to 'wrapping' not working correctly with more than a single wrap. My point was that command is not one someone should be using, which is most likely why the bug hasn't been noticed until now. |
|
Good The issue is not solved. It worked from version Fvwm3 1.0.6 (when I made the configs) until 1.1.0-72. Maybe it was not supposed to work with a multi-desk FvwmPager. When it is changed to another single FvwmPager which only shows the current desk. It works but not immediately at the change. I will post this question on the Fvwm Forums. |
|
Your version number doesn't make sense, the version I see from main is |
This example config was tested in version 1.1.0-72 and 1.1.0-132 with the default-config. Screenshot result. |
|
Okay it took a while to figure out what the bug actually was (partly because your description is fairly poor). But after looking at the screenshots I finally figured out what you mean. If you run FvwmPager on a desk other than 0, it won't be updated until an update desk change happens. I'll look into that. |
When FvwmPager is tracking the current desk and is run on any desk except desk 0, the current desk isn't updated during initialization because the monitor update is sent before the desk update, so the pager didn't realize the desk has changed. This ensures that the page updates the current desk if either the desk changes or the current desk is not the same as the current desk to also catch updates during pager initialization. Fixes #1122
When FvwmPager is tracking the current desk and is run on any desk except desk 0, the current desk isn't updated during initialization because the monitor update is sent before the desk update, so the pager didn't realize the desk has changed. This ensures that the pager updates the current desk if either the desk changes or the new desk is not the same as the current desk to also catch updates during pager initialization. Fixes #1122
When FvwmPager is tracking the current desk and is run on any desk except desk 0, the current desk isn't updated during initialization because the monitor update is sent before the desk update, so the pager didn't realize the desk has changed. This ensures that the pager updates the current desk if either the desk changes or the new desk is not the same as the current desk to also catch updates during pager initialization. Fixes #1122
|
Okay, I see what is going on and fixed the issue. Check out js/gh-1122. In the future try to better describe what the issue is as trying to fish useful information makes it way harder to track down the actual bug. This has nothing to do with changing desks, or remembering what the current desk is. This is about FvwmPager updating the current desk during initialization. |
somiaj
changed the title
When FvwmPager is tracking the current desk and is run on any desk except desk 0, the current desk isn't updated during initialization because the monitor update is sent before the desk update, so the pager didn't realize the desk has changed. This ensures that the pager updates the current desk if either the desk changes or the new desk is not the same as the current desk to also catch updates during pager initialization. Fixes #1122
|
Thanks for the fix, |
Upfront Information
fvwm3 --version)fvwm3 1.1.1 (1.1.0-129) with issue
fvwm3 1.1.1 (1.1.0-119-g360b5bb2) with issue (maybe earlier)
fvwm3 1.1.1 (1.1.0-72) is ok
Expected Behaviour
Remember the Desk when changing from one FvwmPager to another.
Actual Behaviour
Working on Desk 2 (
DesktopName 2 Office) in config "VdeskPager". When changed to config BarButtons withSwallow "FvwmPagerBar"it shows Desk 0 (DesktopName 0 Web). In WorkPager it is ok.Screenshot:
https://rasatpc.net/screenshot/fvwm3/pager-change-issue.png
The text was updated successfully, but these errors were encountered: