Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style PositionPlacement ignores y percentage #265

Closed
afhp-2020 opened this issue Oct 18, 2020 · 6 comments · Fixed by #319
Closed

Style PositionPlacement ignores y percentage #265

afhp-2020 opened this issue Oct 18, 2020 · 6 comments · Fixed by #319
Labels
type:bug Something's broken!
Milestone

Comments

@afhp-2020
Copy link

Given the configuration line defined previously

Style volume-popup.script    PositionPlacement 0 75

the script window is expected to appear at the left of the screen (taking struts into account), 3/4 of the way down as it did previously. Instead, it appears at the top of the screen.

Changing the line (through FvwmConsole) to

Style volume-popup.script    PositionPlacement 0 1000p

makes it appear where expected.

Modifying the x component (as a percentage, without suffix) behaves as expected.

version 1.0.1 (1.0.0-45-gb1072488)

@ThomasAdam ThomasAdam added the type:bug Something's broken! label Oct 18, 2020
@ThomasAdam ThomasAdam added this to the 1.0.2 milestone Oct 18, 2020
@ThomasAdam
Copy link
Member

ThomasAdam commented Oct 18, 2020

Hi @afhp-2020

Oh, good. Looks like I've trampled over some previous value when shoe-horning in RandR.

Don't suppose you're up for submitting a patch to fix this, are you? :)

Have a look at fvwm/move_resize.c:GetMoveArguments() as a starter for ten...

@afhp-2020
Copy link
Author

I'll give it a look, but no promises :) I'm not that much of a C developer. While I'm at it I should also give #40 a shot...

@ThomasAdam
Copy link
Member

ThomasAdam commented Oct 18, 2020

I'll give it a look, but no promises :) I'm not that much of a C developer. While I'm at it I should also give #40 a shot...

Heh, thanks! You don't need to be a C developer, just someone who has more of a brain than I do... ;)

As for #40 -- go for it! I think I recall starting a pull-request to move things along with that, but since I'm generally ambivalent with how iconic windows appear on different monitors for me, I've not really focused on revisiting my fix for that. Selfish programming, eh? :)

@afhp-2020
Copy link
Author

Version 1.0.0-21-ge2c929d5 does not exhibit this bug, 1.0.1 release does.

@ThomasAdam
Copy link
Member

Hi @afhp-2020

Are you saying this is fixed?

@afhp-2020
Copy link
Author

Hi Thomas,

It is not fixed: things worked in a previous, 1.0.0 - level version, and are broken as of 1.0.1.

More specifically, bisecting for #264, it broke on

90f7b45841e534819ebe69232528613069217203 is the first bad commit

(both issues appear simultaneously)

ThomasAdam added a commit that referenced this issue Dec 3, 2020
When computing and setting the EWMH work area (which also implies
EwmhBaseStrut settings), calculate the struts relative to the overall
screen widths and heights.

Certain monitors with certain resolutions combined will often have "dead
space" which calculating per-monitor is a distorted value.  The window's
offset against the work area is calculated when placing/maimizing a
window, so doesn't incur per-monitor offsets.

Fixes #271, fixes #265, fixes #264, fixes #250
ThomasAdam added a commit that referenced this issue Dec 4, 2020
When computing and setting the EWMH work area (which also implies
EwmhBaseStrut settings), calculate the struts relative to the overall
screen widths and heights.

Certain monitors with certain resolutions combined will often have "dead
space" which calculating per-monitor is a distorted value.  The window's
offset against the work area is calculated when placing/maimizing a
window, so doesn't incur per-monitor offsets.

Fixes #271, fixes #265, fixes #264, fixes #250
ThomasAdam added a commit that referenced this issue Dec 6, 2020
When computing and setting the EWMH work area (which also implies
EwmhBaseStrut settings), calculate the struts relative to the overall
screen widths and heights.

Certain monitors with certain resolutions combined will often have "dead
space" which calculating per-monitor is a distorted value.  The window's
offset against the work area is calculated when placing/maimizing a
window, so doesn't incur per-monitor offsets.

Fixes #271, fixes #265, fixes #264, fixes #250
ThomasAdam added a commit that referenced this issue Dec 6, 2020
When computing and setting the EWMH work area (which also implies
EwmhBaseStrut settings), calculate the struts relative to the overall
screen widths and heights.

Certain monitors with certain resolutions combined will often have "dead
space" which calculating per-monitor is a distorted value.  The window's
offset against the work area is calculated when placing/maimizing a
window, so doesn't incur per-monitor offsets.

Fixes #271, fixes #265, fixes #264, fixes #250
@ThomasAdam ThomasAdam moved this to Done in FVWM3 Sep 18, 2022
@ThomasAdam ThomasAdam added this to FVWM3 Sep 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something's broken!
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants