-
-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crash in FvwmPager #833
Comments
Hi @utopiabound AFAICT, this issue should be fixed now. |
This is not fixed in 1.0.7: @ThomasAdam
|
Done. Can you also provide me with a means of reproducing this, please? |
I don't have a reproducer yet, but I'll try to keep an eye on it to figure it out. Do you need any info from the core file? |
Here is the
|
Hi @utopiabound You could help me by providing your FvwmButtons and FvwmPager configs... |
Buttons
Pager:
|
Similar but not identical stack trace of another crash. I didn't see it crash so I'm not sure what I was doing:
|
Thanks, @utopiabound What's the output from |
|
Module boundaries into libs/ in fvwm can sometimes be problematic. As such, calling into X11 libraries with an assumed display variable which is initialised from fvwm, but not from modules, can sometimes mean this isn't guaranteed to work. Implement these X calls local to FvwmPager instead. Fixes #833
Hey @utopiabound Please can you give In looking at your backtraces more closely, I think this is down to modules calling into library code which might not have a fully initialised environment. Easier to move the X11 calls to FvwmPager in this case. |
Module boundaries into libs/ in fvwm can sometimes be problematic. As such, calling into X11 libraries with an assumed display variable which is initialised from fvwm, but not from modules, can sometimes mean this isn't guaranteed to work. Implement these X calls local to FvwmPager instead. Fixes #833
Sorry, I missed this. I've upgraded to 1.0.8 and I still have a crash:
GDB Backtrace:
|
I've finally figured out what is causing it. one of my monitors does a weird "blinky" thing sometimes on return from sleep, but it's more like it disconnects then reconnects. This is the journal from right before the above crash:
|
Ah, thank you, @utopiabound -- I shall see if I can reproduce this and get back to you. |
@ThomasAdam I reproduced with master (2bfde50) FvwmPager
The issues is that on line 478
A clue might be that
That has the same name as the "current" screen, but has the correct |
This is still happening with post-1.0.9 (4de50e9)
Looking at the
It seems to be growing each time the monitor disconnects and reconnects. Do you need anything else? |
Hi @utopiabound Apologies this issues has bounced around a bit. I should be in a position to fix this, so I will take a look. If I need any additional information from you, I'll let you know. |
The fact the list of monitors grows like that tells me where I need to look -- and FvwmPager has always been an oddity in dealing with this. I'll dig further... |
Hi @utopiabound Please can you try the FInger's crossed! |
I have not had a recurrence of this issue since updating. I believe this is fixed. |
@utopiabound Can you test #972, we have done a lot of changes to the pager and improving both |
Thanks for reporting your bug here! The following template will help with
giving as much information as possible so that it's easier to diagnose and
fix.
Upfront Information
Please provide the following information by running the command and providing
the output.
fvwm3 --version
)Fedora 37
uname -sp
)Expected Behaviour
FvwmPager just runs inside an FvwmButtons instance.
Actual Behaviour
Usually runs but occasionally crashes
Enabling logging
Output of crashdumpctl backtrace:
Debugging of core:
Steps to Reproduce
No reproduction case yet.
Extra Information
Dual monitor setup.
The text was updated successfully, but these errors were encountered: