Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InfoStore: rewrite internals to use TAILQ instead of a linked list. #993

Closed
ThomasAdam opened this issue Apr 3, 2024 · 0 comments · Fixed by #1113
Closed

InfoStore: rewrite internals to use TAILQ instead of a linked list. #993

ThomasAdam opened this issue Apr 3, 2024 · 0 comments · Fixed by #1113
Labels
difficulty:easy Issue is suitable for new fvwm developer difficulty:gfi Issue is suitable for a first-time contributor/developer type:internal-improvement Issue is an internal improvement (cleanup, etc.)
Milestone
1.1.1

Comments

@ThomasAdam
Copy link
Member

When InfoStore was written, TAILQ wasn't being used. We should change its implementation over to use TAILQ which will reduce some of the overhead of a heap-allocated structure.
@ThomasAdam ThomasAdam added difficulty:easy Issue is suitable for new fvwm developer difficulty:gfi Issue is suitable for a first-time contributor/developer labels Apr 3, 2024
@ThomasAdam ThomasAdam added this to the 1.1.1 milestone Apr 3, 2024
@ThomasAdam ThomasAdam added this to FVWM3 Apr 3, 2024
@github-project-automation github-project-automation bot moved this to To do in FVWM3 Apr 3, 2024
@ThomasAdam ThomasAdam removed this from the 1.1.1 milestone Oct 5, 2024
somiaj added a commit that referenced this issue Nov 18, 2024
@somiaj
Convert InfoStore to TAILQ.
0b4204f 
Use TAILQ instead of a linked list for InfoStore. This also reduces
looping over the list multiple times in some situations.

This fixes #993.
somiaj added a commit that referenced this issue Nov 18, 2024
@somiaj
Convert InfoStore to TAILQ.
4c5727d 
Use TAILQ instead of a linked list for InfoStore. This also reduces
looping over the list multiple times in some situations.

This fixes #993.
somiaj added a commit that referenced this issue Nov 18, 2024
@somiaj
Convert InfoStore to TAILQ.
e344819 
Use TAILQ instead of a linked list for InfoStore. This also reduces
looping over the list multiple times in some situations.

This fixes #993.
somiaj added a commit that referenced this issue Nov 18, 2024
@somiaj
Convert InfoStore to TAILQ.
502366f 
Use TAILQ instead of a linked list for InfoStore. This also reduces
looping over the list multiple times in some situations.

This fixes #993.
somiaj added a commit that referenced this issue Nov 18, 2024
@somiaj
Convert InfoStore to TAILQ.
7980e2b 
Use TAILQ instead of a linked list for InfoStore. This also reduces
looping over the list multiple times in some situations.

This fixes #993.
@somiaj somiaj mentioned this issue Nov 18, 2024
Merged
somiaj added a commit that referenced this issue Nov 18, 2024
@somiaj
Convert InfoStore to TAILQ.
4c3d577 
Use TAILQ instead of a linked list for InfoStore. This also reduces
looping over the list multiple times in some situations.

This fixes #993.
@github-project-automation github-project-automation bot moved this from To do to Done in FVWM3 Nov 18, 2024
@ThomasAdam ThomasAdam added this to the 1.1.1 milestone Nov 18, 2024
@ThomasAdam ThomasAdam added the type:internal-improvement Issue is an internal improvement (cleanup, etc.) label Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty:easy Issue is suitable for new fvwm developer difficulty:gfi Issue is suitable for a first-time contributor/developer type:internal-improvement Issue is an internal improvement (cleanup, etc.)
Projects
FVWM3
Status: Done
Milestone
1.1.1
Development

Successfully merging a pull request may close this issue.

Convert InfoStore to TAILQ. fvwmorg/fvwm3
1 participant
@ThomasAdam