FvwmCommand: use FVWMMFL_SOCKET when it's present #1035
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow-up to da4387b FvwmMFL: introduce FVWMML_SOCKET_PATH for namespacing. It breaks FvwmCommand for me because instead of taking FVWMMFL_SOCKET from the environment, FvwmCommand guesses it from FVWMMFL_SOCKET_PATH (incorrectly, DISPLAY=:1.0 while socket being :1.sock) When running FvwmCommand from a specific fvwm instance, FVWMMFL_SOCKET is available, so let FvwmCommand use it. In the "outer" environment where only FVWMML_SOCKET_PATH is available, let it resort to guessing socket by $DISPLAY. Fixes fvwmorg#1034.
|
Damn... I missed that you'd done this, @akovalenko -- sorry. Is this PR still required? |
|
Fixed via PR f6dd682 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to da4387b FvwmMFL: introduce FVWMML_SOCKET_PATH for namespacing. It breaks FvwmCommand for me because instead of taking FVWMMFL_SOCKET from the environment, FvwmCommand guesses it from FVWMMFL_SOCKET_PATH (incorrectly, DISPLAY=:1.0 while socket being :1.sock)
When running FvwmCommand from a specific fvwm instance, FVWMMFL_SOCKET is available, so let FvwmCommand use it. In the "outer" environment where only FVWMML_SOCKET_PATH is available, let it resort to guessing socket by $DISPLAY. Fixes #1034.