Fix issue with placement in per-monitor configuration. #1076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When two monitors are on different desks, ensure that the correct monitor is used when placing windows. Otherwise placement policies can use the wrong desk when computing where to place a window. This is done two fold, first initialize windows with a NULL monitor so current monitor is used in cases a monitor is not specified for the window to start on, and second delay updating the window's monitor until after the window has been placed, so the correct monitor is found based on the windows location. This fixes #1043.
ThomasAdam
added
type:bug
somiaj
added a commit
that referenced
this pull request
Nov 5, 2024
It is possible that the FvwmWindow monitor is NULL, that can cause a crash when broadcasting the window's configuration to packet modules by referencing a NULL pointer to send the monitor's ID. This now happens with StartsOnPage due to #1076 setting the monitor to NULL initially. This fix ensures that the monitor is always defined after processing any StartsOnScreen settings, by setting it to the current monitor if it is still NULL. Also ensuring the monitor is defined here simplifies some future checks that were doing the same thing by falling back to the current monitor if it was undefined. This fixes the crash reported in #1100.
somiaj
added a commit
that referenced
this pull request
Nov 6, 2024
It is possible that the FvwmWindow monitor is NULL, that can cause a crash when broadcasting the window's configuration to packet modules by referencing a NULL pointer to send the monitor's ID. This now happens with StartsOnPage due to #1076 setting the monitor to NULL initially. This fix ensures that the monitor is always defined after processing any StartsOnScreen settings, by setting it to the current monitor if it is still NULL. Also ensuring the monitor is defined here simplifies some future checks that were doing the same thing by falling back to the current monitor if it was undefined. This fixes the crash reported in #1100.
ThomasAdam
pushed a commit
that referenced
this pull request
Nov 7, 2024
It is possible that the FvwmWindow monitor is NULL, that can cause a crash when broadcasting the window's configuration to packet modules by referencing a NULL pointer to send the monitor's ID. This now happens with StartsOnPage due to #1076 setting the monitor to NULL initially. This fix ensures that the monitor is always defined after processing any StartsOnScreen settings, by setting it to the current monitor if it is still NULL. Also ensuring the monitor is defined here simplifies some future checks that were doing the same thing by falling back to the current monitor if it was undefined. This fixes the crash reported in #1100.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When two monitors are on different desks, ensure that the correct monitor is used when placing windows. Otherwise placement policies can use the wrong desk when computing where to place a window. This is done two fold, first initialize windows with a NULL monitor so current monitor is used in cases a monitor is not specified for the window to start on, and second delay updating the window's monitor until after the window has been placed, so the correct monitor is found based on the windows location.
This fixes #1043.