Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PrintInfo: bindings: reduce duplication #1094

Merged
merged 1 commit into from
Oct 29, 2024
Merged

PrintInfo: bindings: reduce duplication #1094

merged 1 commit into from
Oct 29, 2024

Conversation

ThomasAdam
Copy link
Member

Simplify the flag checking for Key/Mouse bindings.

Simplify the flag checking for Key/Mouse bindings.
@ThomasAdam ThomasAdam added type:bug Something's broken! skip:changelog Issue/PR should skip CHANGELOG labels Oct 29, 2024
@ThomasAdam ThomasAdam self-assigned this Oct 29, 2024
@somiaj
Copy link
Collaborator

somiaj commented Oct 29, 2024

Tested this works. Though there are two tabs between the key/mouse name and the context.

[1730202172.267249] print_bindings:     Key     Up                      TWFS    CM      ShuffleDir up

@ThomasAdam
Copy link
Member Author

That's fine with me -- it's because of the missing (window_name) binding.

It's only meant for debug purposes.

@ThomasAdam ThomasAdam added this to the 1.1.1 milestone Oct 29, 2024
@ThomasAdam ThomasAdam merged commit d1c81a4 into main Oct 29, 2024
12 checks passed
@ThomasAdam ThomasAdam deleted the ta/pb branch October 29, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip:changelog Issue/PR should skip CHANGELOG type:bug Something's broken!
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants